Bug report #13680

compile fails attempting to generate qgsversion.h

Added by William Kyngesburye over 1 year ago. Updated about 1 year ago.

Status:Closed Start Date:10/26/2015
Priority:Normal Due date:
Assigned to:- % Done:

0%

Category:Build / Install
Target version:-
Platform:OS X Pull Request or Patch supplied:No
Platform version: Affected version:master
Status info: Causes crash or corruption:No
Resolution: Tag:

Description

In QGIS 2.10, qgsversion was set wrong (empty), but at least it was set. Now in 2.12 (release) it causes compilation to fail with:

fatal: Not a git repository (or any of the parent directories): .git
make[2]: *** [qgsversion.h] Error 128
make[1]: *** [CMakeFiles/version.dir/all] Error 2

It looks like the problem is that cmake is misidentifying the release source as a git repository, then it uses git to try to generate the version string, instead of the "exported" it should be.

FIND_FILE(GIT_MARKER index PATHS ${CMAKE_SOURCE_DIR}/.git)

According to the cmake docs, PATHS adds to a set of standard paths find_file looks in, and it ends up finding the "index" header in GEOS. To make it only look in the source/.git for the marker, add the NO_DEFAULT_PATH flag to find_file, like:

FIND_FILE(GIT_MARKER index NO_DEFAULT_PATH PATHS ${CMAKE_SOURCE_DIR}/.git)

Associated revisions

History

Updated by Giovanni Manghi over 1 year ago

  • Target version deleted (Version 2.12)

Updated by Jürgen Fischer about 1 year ago

  • Status changed from Open to Closed

Also available in: Atom