Bug report #5616

"Add" button is enabled when no PostGIS layers are selected

Added by Mike Toews almost 5 years ago. Updated 11 months ago.

Status:Closed Start Date:05/18/2012
Priority:Low Due date:
Assigned to:- % Done:

0%

Category:GUI
Target version:Future Release - Lower Priority
Platform: Pull Request or Patch supplied:No
Platform version: Affected version:master
Status info: Causes crash or corruption:No
Resolution: Tag:

Description

In the "Add PostGIS Table(s)" dialog, when no layers are selected, the "Add" button is enabled. Clicking this button shows an information dialog:

You must select a table in order to add a layer.

Although this is all logical at a basic level, it could be confusing to the user. Particularly if they had already selected a layer, then double-clicked it to build a query, and the layer became unselected. The "Add" button should only be enabled when there are greater than zero layers selected, otherwise it should be disabled.

As a minor touch-up, the dialog does not list PostGIS "tables", rather they are layers (as the pop-up text shows for the icon). These can be any number of combinations of tables and/or views with one or more geometry/geography columns .. or simply put, layers.

Associated revisions

Revision 7132209fa0965a217d48feeaba1f0ef30a68e91c
Added by Alexander Bruy 11 months ago

enable Add button in DB dialogs only when at least one table is selected (fix #5616)

Revision 427559c872280618c9cc632f36e5f7b04c62faf5
Added by Alexander Bruy 11 months ago

Merge pull request #3100 from alexbruy/add-db-table

enable Add button in DB dialogs only when at least one table is selected (fix #5616)

History

Updated by Paolo Cavallini over 4 years ago

  • Target version set to Version 2.0.0

Updated by Giovanni Manghi almost 3 years ago

  • Target version changed from Version 2.0.0 to Future Release - Lower Priority

Updated by Médéric RIBREUX over 1 year ago

Hello, bug triage...

still true in QGIS 2.13...

Updated by Alexander Bruy 11 months ago

  • Status changed from Open to Closed

Also available in: Atom