Bug #6018

fTools:Select by location is confusing, especially with an empty selection

Added by Leyan Ouyang 11 months ago. Updated 10 months ago.

Status:New Start Date:07/11/2012
Priority:Normal Due date:
Assigned to:- % Done:

0%

Category:fTools
Target version:Version 2.0.0
Platform: Patch supplied:No
Platform version: Affected version:master
Status info: Causes crash or corruption:No
Resolution:

Description

I used "Select by location" in the fTools plugin, with the options to use selected features only. The progress bar started the movement left and right used for an unknown amount of remaining time, so I waited, surprised that my small data set was so hard to select.

Actually, the selection was empty and no calculation was happening, but it took me the longest time to realize it. The problem is twofold:
  • nothing prevents using an empty selection (even if it cannot be useful), but self.progressBar.setMaximum(len(features)) on line 114 of doSelectByLocation.py does not have the expected result when features is an empty list as it makes an endlessly moving progress bar
  • More globally, the plugin doesn't indicate anything when the computation is finished. I would have expected either closing the window or at least showing a message indicating the number of selected features. Something like: "%d features have been selected, the existing selection had %d features, the new selection has %d features" % (nbSelected, nbPrevious, nbEndResult) ))@ at the end of the compute() function

History

Updated by Paolo Cavallini 10 months ago

  • Target version set to Version 2.0.0

Also available in: Atom PDF